Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest for test_analysis and fix test #678

Open
wants to merge 3 commits into
base: protos
Choose a base branch
from
Open

Use pytest for test_analysis and fix test #678

wants to merge 3 commits into from

Conversation

oerc0122
Copy link
Collaborator

@oerc0122 oerc0122 commented Feb 21, 2025 •
edited
Loading

Description of work

  • Migrate from unittest to pytest
  • Parametrise tests to add capacity for further testing
  • Merge test_molecular_dynamics with test_analysis

Fixes

  • Fix bad test which claims to run radius_of_gyration with root, but actually runs mean_square_fluctuation

To test
Standard tests

@oerc0122 oerc0122 added the CI/CD Something concerning the CI/CD pipeline label Feb 21, 2025
@oerc0122 oerc0122 self-assigned this Feb 21, 2025
MBartkowiakSTFC
MBartkowiakSTFC approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't see any problems.

@oerc0122 oerc0122 force-pushed the pytestise-test-analysis branch from d3c0f46 to 0a9f7ee Compare February 24, 2025 16:53
@oerc0122 oerc0122 force-pushed the pytestise-test-analysis branch from e063d2c to a640083 Compare February 25, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBartkowiakSTFC MBartkowiakSTFC MBartkowiakSTFC approved these changes

@ChiCheng45 ChiCheng45 Awaiting requested review from ChiCheng45

Assignees

@oerc0122 oerc0122

Labels
CI/CD Something concerning the CI/CD pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oerc0122 @MBartkowiakSTFC